cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Girish Chaudhari" <girish.chaudh...@sungard.com>
Subject Re: Review Request 23395: CLOUDSTACK-5663 :- Handled the NULL check for network's cidr field to avoid NPE for createNetwork and listNetwork
Date Thu, 24 Jul 2014 10:45:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23395/
-----------------------------------------------------------

(Updated July 24, 2014, 10:45 a.m.)


Review request for cloudstack, daan Hoogland and Parth Jagirdar.


Bugs: CLOUDSTACK-5663
    https://issues.apache.org/jira/browse/CLOUDSTACK-5663


Repository: cloudstack-git


Description
-------

CLOUDSTACK-5663 - API:MS: Network with NULL CIDR raises NPE for createNetwork and listNetwork

Root Cause:
In the listNetworks and createNetworks API execution flow, existing networks analysed to check
whether they can be used for deploy. In this step, all the available IPs are calculated using
the Network CIDR. In case the CIDR is NULL it results into the NPE. 

Solution:
Added the NULL check to avoid NPE, in case of NULL CIDR, API populate the "canusefordeploy"
attribute as false.


Diffs
-----

  server/src/com/cloud/network/NetworkModelImpl.java 0ef5cb9 

Diff: https://reviews.apache.org/r/23395/diff/


Testing
-------

Tested on master for listNetworks and createNetwork command with NULL network cidr. 


Thanks,

Girish Chaudhari


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message