cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilia Shakitko" <>
Subject Re: Review Request 23805: Added "state" parameter to the "listPublicIpAddresses" API call
Date Thu, 24 Jul 2014 08:47:10 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 24, 2014, 8:47 a.m.)

Review request for cloudstack, Alena Prokharchyk, Alex Huang, Harikrishna Patnala, Prachi
Damle, Rohit Yadav, Ilia Shakitko, and Wei Zhou.


Repository: cloudstack-git


This improvement is introducing a new parameter for the "listPublicIpAddresses" API call -

Few times we've faced an impedemence of having a list of "Free" publicIpAddresses. You have
to go thru all the IPs with (allocatedonly = false) and filter out the "Free" once. It's not
a big deal, but it's an extra time and traffic between CloudStack and an API consumer.

I also moved few methods out of the 'API Implementation' and put them above as a minor refactoring.
Method "getForLoadBalancing" has been removed because it's not being used in code anywhere

This patch is done for "master" branch.


  api/src/org/apache/cloudstack/api/command/user/address/ 07ccfe9

  server/src/com/cloud/server/ 99b12732 



1) Build successfull
2) No tests broken
3) Tested few different calls with cloudmonkey:

list publicipaddresses forvirtualnetwork=false listall=true page=1 pagesize=0
count = 10

list publicipaddresses forvirtualnetwork=false listall=true allocatedonly=false page=1 pagesize=0
count = 100

list publicipaddresses forvirtualnetwork=false listall=true state=free page=1 pagesize=0
count = 90


Ilia Shakitko

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message