cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miguel Ferreira" <miguelferre...@me.com>
Subject Re: Review Request 23735: Fix deployment of data center with marvin
Date Thu, 24 Jul 2014 08:22:30 GMT


> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinLog.py, line 168
> > <https://reviews.apache.org/r/23735/diff/1/?file=636742#file636742line168>
> >
> >     Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the
logfile path, as similar to create log from directory, where we pass log folder dir.
> 
> Santhosh Edukulla wrote:
>     Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile
path, as similar to create log from directory, where we pass log folder dir. 
>
> 
> Miguel Ferreira wrote:
>     I don't see where where is the difference in abstraction level you mention.
>     Both methods createLogFromFile and createLogFromDirectory receive a log_cfg object,
that is already received as a parameter from the method above in the call stack (createLogs).
Thus, all three methods are at the same abstraction level in that respect.

Do you mean making createLogFromFile and createLogFromDirectory agnostic about the log_cfg
structure?
Cause that seems an improvement to me.


- Miguel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------


On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 7:24 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo
Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking
with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
> 
> 
> However, that produces the error message bellow:
> 
>  	Exception Occurred Under createLogs :['Traceback (most recent call last):\n', '  File
"/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157,
in createLogs\n    (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError:
'list' object has no attribute '__dict__'\n"]
> 
> 	===Log Creation Failed. Please Check===
> 
> 
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
> 
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py ae48839 
>   tools/marvin/marvin/marvinLog.py ea8eaee 
> 
> Diff: https://reviews.apache.org/r/23735/diff/
> 
> 
> Testing
> -------
> 
> With the patch I was able to deploy a zone in cloudstack.
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message