cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miguel Ferreira" <miguelferre...@me.com>
Subject Re: Review Request 23847: Check if config specifies zones before iterating
Date Wed, 23 Jul 2014 12:10:04 GMT


> On July 23, 2014, 12:05 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinInit.py, line 114
> > <https://reviews.apache.org/r/23847/diff/1/?file=640532#file640532line114>
> >
> >     please use is not None, rather !=

I will do this this time, but if something is broken, I fix it and you see better ways of
fixing it, please be my guest and do it yourself. after all that is the spirit of open-source,
right?


- Miguel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23847/#review48496
-----------------------------------------------------------


On July 23, 2014, 11:56 a.m., Miguel Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23847/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 11:56 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Santhosh Edukulla, and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Running a marvin test that does not specify a zone in the config file will produce an
exception while parsing the config:
> 
> Exception Occurred Under init ['Traceback (most recent call last):\n', '  File "/usr/local/lib/python2.7/site-packages/marvin/marvinInit.py",
line 118, in __setHypervisorAndZoneInfo\n    for zone in self.__parsedConfig.zones:\n', "TypeError:
'NoneType' object is not iterable\n"]
> 
> This happens when the code starts iterating over a list of zones that does not exist.
> I've added a check for the existence of the list of zones before iterating.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/marvinInit.py ce9b43f 
> 
> Diff: https://reviews.apache.org/r/23847/diff/
> 
> 
> Testing
> -------
> 
> Tests now run without the mentioned exception
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message