cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ritu Sabharwal" <rsabh...@brocade.com>
Subject Re: Review Request 22863: CLOUDSTACK-6823 : First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.
Date Tue, 22 Jul 2014 19:19:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22863/
-----------------------------------------------------------

(Updated July 22, 2014, 7:19 p.m.)


Review request for cloudstack and Hugo Trippaers.


Changes
-------

Fixed the 2 Findbug findings.


Bugs: CLOUDSTACK-6823
    https://issues.apache.org/jira/browse/CLOUDSTACK-6823


Repository: cloudstack-git


Description
-------

First code drop for Brocade Network plugin to orchestrate Brocade VDX switches for L2 connectivity.
Please create a new branch for Brocade plugin.


Diffs (updated)
-----

  api/src/com/cloud/network/Network.java 0a08f28 
  api/src/com/cloud/network/Networks.java 1ad3350 
  api/src/com/cloud/network/PhysicalNetwork.java 024b3ce 
  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java e73f526 
  client/WEB-INF/classes/resources/messages.properties bb75b08 
  client/WEB-INF/classes/resources/messages_zh_CN.properties d7a0ca9 
  client/pom.xml 410cb19 
  client/tomcatconf/commands.properties.in aa03949 
  plugins/network-elements/brocade-vcs/pom.xml PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadeInterfaceSchema.xsd PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/BrocadePortProfileSchema.xsd PRE-CREATION

  plugins/network-elements/brocade-vcs/resources/BrocadeShowVcsSchema.xsd PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/module.properties
PRE-CREATION 
  plugins/network-elements/brocade-vcs/resources/META-INF/cloudstack/vcs/spring-vcs-context.xml
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkAnswer.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/AssociateMacToNetworkCommand.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkAnswer.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/CreateNetworkCommand.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkAnswer.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DeleteNetworkCommand.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkAnswer.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/DisassociateMacFromNetworkCommand.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/agent/api/StartupBrocadeVcsCommand.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/AddBrocadeVcsDeviceCmd.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/DeleteBrocadeVcsDeviceCmd.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDeviceNetworksCmd.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/api/commands/ListBrocadeVcsDevicesCmd.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsDeviceVO.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/network/BrocadeVcsNetworkVlanMappingVO.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApiException.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/Constants.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDao.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsDaoImpl.java PRE-CREATION

  plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDao.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/dao/BrocadeVcsNetworkVlanMappingDaoImpl.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElement.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/element/BrocadeVcsElementService.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/guru/BrocadeVcsGuestNetworkGuru.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/src/com/cloud/network/resource/BrocadeVcsResource.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/test/com/cloud/network/brocade/BrocadeVcsApiTest.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/test/com/cloud/network/guru/BrocadeVcsGuestNetworkGuruTest.java
PRE-CREATION 
  plugins/network-elements/brocade-vcs/test/com/cloud/network/resource/BrocadeVcsResourceTest.java
PRE-CREATION 
  plugins/pom.xml eff5a01 
  setup/db/db/schema-440to450.sql 6cb81c6 
  test/integration/component/test_brocade_vcs.py PRE-CREATION 
  tools/apidoc/gen_toc.py bcc8417 
  ui/dictionary.jsp c84d0dd 
  ui/scripts/system.js 502007f 
  ui/scripts/ui-custom/zoneWizard.js 645c2b1 

Diff: https://reviews.apache.org/r/22863/diff/


Testing
-------

•	Create an isolated network; verify that the port-profile is created on the Brocade switch.
•	Attach a VM to the network; verify that the VMs MAC address is associated with the port
profile of the network on the Brocade switch.
•	Delete VMs for an isolated network; verify that the VMs MAC address is disassociated with
the port profile of the network on the Brocade switch.
•	Delete the isolated network; verify that the port-profile is deleted from the Brocade
switch.

Integration test result:

Test Brocade Network and VM Creation ... === TestName: test_network_vcs | Status : SUCCESS
===
ok

----------------------------------------------------------------------
Ran 1 test in 297.497s

OK


File Attachments
----------------

Diff for the existing cloudstack code
  https://reviews.apache.org/media/uploaded/files/2014/06/23/8fc3cfb1-7a21-4714-98f3-6514cf54ba84__diff
Patch file for Brocade functionality code
  https://reviews.apache.org/media/uploaded/files/2014/06/26/92bb0014-a7b7-4f0b-97c9-018d615b658a__brocade-vcs.patch


Thanks,

Ritu  Sabharwal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message