cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 23735: Fix deployment of data center with marvin
Date Tue, 22 Jul 2014 08:05:56 GMT


> On July 21, 2014, 1:56 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/deployDataCenter.py, line 1099
> > <https://reviews.apache.org/r/23735/diff/1/?file=636741#file636741line1099>
> >
> >     Instead of this, can we make "logger" node under devcloud.cfg as similar to
setup/dev/advanced.cfg. We never see a case of for loop to create multiple loggers and logs?
> >     
> >
> 
> Miguel Ferreira wrote:
>     There are more configurations that use lists of loggers then otherwise.
>     I didn't assume on way t be better than another simply because I don't know.
>     
>     see:
>     tools/marvin$ find .. -type f -iname '*.cfg' | xargs grep logger
>     ../devcloud/devcloud-advanced.cfg:    "logger": [
>     ../devcloud/devcloud-advanced_internal-mgt.cfg:    "logger": [
>     ../devcloud/devcloud-advanced_juniper-contrail.cfg:    "logger": [
>     ../devcloud/devcloud-advancedsg.cfg:    "logger": [
>     ../devcloud/devcloud.cfg:    "logger":
>     ../devcloud/devcloud_internal-mgt.cfg:    "logger": [
>     ../devcloud/devcloud_s3.cfg:    "logger": [
>     ../devcloud/quickcloud.cfg:    "logger": [
>     ../devcloud-kvm/devcloud-kvm-advanced-fusion.cfg:    "logger": {
>     ../devcloud-kvm/devcloud-kvm-advanced.cfg:    "logger": [
>     ../devcloud-kvm/devcloud-kvm.cfg:    "logger": [
>     ../marvin/marvin/config/setup.cfg:    "logger":
>     ../marvin/marvin/misc/build/asf_test.cfg:    "logger": [
>     ../marvin/marvin/misc/build/kvm.cfg:    "logger": [
>     ../marvin/marvin/misc/build/xen.cfg:    "logger": [

Yeah, there were few places where lists of loggers are used. Some of these config files are
not used or rarely used. List of loggers support is not available inside framework, i.e.,
no differentiation between the earlier mentioned client and case log, so please follow according
to advanced.cfg and if other cfgs needs modification, we can do accordingly.


- Santhosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------


On July 22, 2014, 7:24 a.m., Miguel Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 7:24 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo
Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking
with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
> 
> 
> However, that produces the error message bellow:
> 
>  	Exception Occurred Under createLogs :['Traceback (most recent call last):\n', '  File
"/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157,
in createLogs\n    (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError:
'list' object has no attribute '__dict__'\n"]
> 
> 	===Log Creation Failed. Please Check===
> 
> 
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
> 
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py ae48839 
>   tools/marvin/marvin/marvinLog.py ea8eaee 
> 
> Diff: https://reviews.apache.org/r/23735/diff/
> 
> 
> Testing
> -------
> 
> With the patch I was able to deploy a zone in cloudstack.
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message