cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 23609: Signature changes to delete method in VirtualMachine class in base.py
Date Tue, 22 Jul 2014 06:21:21 GMT


> On July 21, 2014, 2:36 p.m., Santhosh Edukulla wrote:
> > Ship It!

please add bugid.


- Santhosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23609/#review48224
-----------------------------------------------------------


On July 17, 2014, 9:22 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23609/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 9:22 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> destroyVirtualMachine API takes only one parameter (id-virtualmachine id) till CS 4.2.
In 4.3 we have added expunge parameter to expunge the vm at the destroy time instead of waiting
for expunge interval.
> Made changes to delete method to accept additional parameters.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/lib/base.py e9d5bb4 
> 
> Diff: https://reviews.apache.org/r/23609/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message