cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 23735: Fix deployment of data center with marvin
Date Mon, 21 Jul 2014 13:56:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23735/#review48216
-----------------------------------------------------------



tools/devcloud/devcloud-advanced.cfg
<https://reviews.apache.org/r/23735/#comment84571>

    Is this change required, compared to earlier devcloud cfg, it was a working cfg for devcloud.



tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/23735/#comment84569>

    Instead of this, can we make "logger" node under devcloud.cfg as similar to setup/dev/advanced.cfg.
We never see a case of for loop to create multiple loggers and logs?
    
    



tools/marvin/marvin/marvinLog.py
<https://reviews.apache.org/r/23735/#comment84570>

    Make it more abstract and see if is not aware of cfg(log_cfg), i mean pass the logfile
path, as similar to create log from directory, where we pass log folder dir. 



tools/marvin/marvin/marvinLog.py
<https://reviews.apache.org/r/23735/#comment84572>

    As well, not related to this line though, can we please test using the simulator and advanced.cfg
to launch management server and deploy a datacenter.


- Santhosh Edukulla


On July 21, 2014, 1:35 p.m., Miguel Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23735/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 1:35 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, John Dilley, Santhosh Edukulla, and Hugo
Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The DevCloud wiki page [1] instructs developers to deploy a DC with basic networking
with the following command:
> $ python tools/marvin/marvin/deployDataCenter.py -i tools/devcloud/devcloud-advanced.cfg
> 
> 
> However, that produces the error message bellow:
> 
>  	Exception Occurred Under createLogs :['Traceback (most recent call last):\n', '  File
"/Users/mferreira/development/git/cloudstack-sbp/tools/marvin/marvin/marvinLog.py", line 157,
in createLogs\n    (\'LogFolderPath\' in log_cfg.__dict__.keys()) and\n', "AttributeError:
'list' object has no attribute '__dict__'\n"]
> 
> 	===Log Creation Failed. Please Check===
> 
> 
> The cause of the error is the unexpected format of the logger element in tools/devcloud/devcloud-advanced.cfg
> The patch I'm submitting add support for lists in the logger element of the configuration.
> 
> In addition the patch also provides small fixes for the deployment configuration of basic
and advanced zones.
> 
> 
> [1] - https://cwiki.apache.org/confluence/display/CLOUDSTACK/DevCloud
> 
> 
> Diffs
> -----
> 
>   tools/devcloud/devcloud-advanced.cfg 74b6366 
>   tools/devcloud/devcloud.cfg 5232e3a 
>   tools/marvin/marvin/deployDataCenter.py ae48839 
>   tools/marvin/marvin/marvinLog.py ea8eaee 
> 
> Diff: https://reviews.apache.org/r/23735/diff/
> 
> 
> Testing
> -------
> 
> With the patch I was able to deploy a zone in cloudstack.
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message