cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "punith s" <punit...@cloudbyte.com>
Subject Re: Review Request 23410: Improvised CloudByte Storage Plugin for 4.5 and above. jira id : CLOUDSTACK-7098
Date Wed, 16 Jul 2014 06:23:22 GMT


> On July 16, 2014, 10:25 a.m., Mike Tutkowski wrote:
> > server/src/com/cloud/configuration/Config.java, line 1942
> > <https://reviews.apache.org/r/23410/diff/2/?file=628420#file628420line1942>
> >
> >     Perhaps I'm having trouble with Review Board, but it appears there are still
CloudByte-specific values in server/src/com/cloud/configuration/Config.java.
> >     
> >     I see that they get inserted from ElastistorPrimaryDataStoreProvider.java, as
well.
> >     
> >     Isn't ElastistorPrimaryDataStoreProvider.java the only place we want to insert
them from?
> >     
> >     Thanks for clarifying

hi mike,

i guess you might be referring to an older diff revision or some problem with the review board!
you can verify revision 3 in this link where i see config.java has been removed, https://reviews.apache.org/r/23410/diff/
also you can get the raw diff from https://reviews.apache.org/r/23410/diff/raw/

thanks
 


- punith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23410/#review47858
-----------------------------------------------------------


On July 15, 2014, 7:48 p.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23410/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 7:48 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das, edison su, and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The new improvised cloudbyte plugin for cloudstack supports the following features
> 
> * support for managed storage, where each vm disk has the guaranteed QoS.
> 
> * supports resize of the volume.
> 
> * supports both iscsi and nfs protocols in XEN server, and iscsi protocol for KVM and
vmware ESX with respect to managed storage.
> 
> * supports storage level snapshot capabilites as well as hypervisor level snapshot feature.
> 
> * also exposing the custom api's for better ui integration.
> 
> * support for unlimited storage nodes across the sites.
> 
> * account integration in cloudbyte with respect to domains in cloudstack.
> 
> 
> Diffs
> -----
> 
>   plugins/storage/volume/cloudbyte/resources/META-INF/cloudstack/storage-volume-cloudbyte/spring-storage-volume-cloudbyte-context.xml
87c5f51 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/driver/ElastistorPrimaryDataStoreDriver.java
99d1e2a 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java
33004e3 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorHostListener.java
de4711a 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/provider/ElastistorPrimaryDataStoreProvider.java
e591082 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorUtil.java
b75d12a 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiService.java
PRE-CREATION 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ElastistorVolumeApiServiceImpl.java
PRE-CREATION 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceCmd.java
PRE-CREATION 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorInterfaceResponse.java
PRE-CREATION 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolCmd.java
PRE-CREATION 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorPoolResponse.java
PRE-CREATION 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeCmd.java
PRE-CREATION 
>   plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/util/ListElastistorVolumeResponse.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23410/diff/
> 
> 
> Testing
> -------
> 
> system testing done.
> 
> 
> Thanks,
> 
> punith s
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message