cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris van Lieshout" <jvanliesh...@schubergphilis.com>
Subject Re: Review Request 23448: Disable in-band management of OVS on cloud_link_local_network on XenServer
Date Mon, 14 Jul 2014 09:14:17 GMT


> On July 14, 2014, 8:52 a.m., daan Hoogland wrote:
> > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java,
line 4464
> > <https://reviews.apache.org/r/23448/diff/1/?file=629579#file629579line4464>
> >
> >     should this only be checked for the first interface?
> >     Ans should it only be set if it allready exists?

In deed I forgot the exclamation mark. Because I'm not changing the code logic (linklocal
uses the first network only) I therefore do not iterate through all networks. Besides that
I cannot imagine that it will contain more then one network.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23448/#review47710
-----------------------------------------------------------


On July 14, 2014, 9:11 a.m., Joris van Lieshout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23448/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 9:11 a.m.)
> 
> 
> Review request for cloudstack, Alex Huang, daan Hoogland, and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-7103
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7103
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> By default XenServer uses Openvswitch and has in-band management enabled on any new network.
This is not desirable for the cloud_link_local_network. This can be disabled by setting the
network's other config parameter vswitch-disable-in-band to true.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
a9840bd 
> 
> Diff: https://reviews.apache.org/r/23448/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message