cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitry Batkovich" <batya...@gmail.com>
Subject Re: Review Request 21776: AWSAPI: cloudstack api on POST requests (instead GET), ssl enabling fixed
Date Sat, 05 Jul 2014 19:14:35 GMT


> On June 24, 2014, 11:10 p.m., Demetrius Tsitrelis wrote:
> > The only change I can see regarding "SSL enabling" is to the getProperty() method
for the default value.  It looks like that change to null wouldn't matter as the constructor
for CloudStackApi() would just reassign 8080?

Maybe I don't understand you but states of properties "cloudAPISSLEnabled" and "cloudAPIPort"
are independent. And port value not depends on "cloudAPISSLEnabled" value. (I will assume
that you look at not my code)


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21776/#review46589
-----------------------------------------------------------


On May 27, 2014, 8:04 p.m., Dmitry Batkovich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21776/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 8:04 p.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Prachi Damle.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for
supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
> 
> continuation of https://reviews.apache.org/r/17586/
> 
> 
> Diffs
> -----
> 
>   awsapi/conf/ec2-service.properties.in 82f5ad8 
>   awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214 
>   awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea 
>   awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210 
>   awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96 
>   awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION 
>   awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68 
>   awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION 
>   awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a 
>   awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59 
>   awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21776/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Batkovich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message