cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script
Date Wed, 02 Jul 2014 14:03:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/#review47186
-----------------------------------------------------------


Hi, no it does not apply cleanly to current 4.3 branch. Can you rebase.

thanks

- Sebastien Goasguen


On June 18, 2014, 10:15 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22721/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 10:15 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-6926
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6926
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> used to readlink -e and dirname to get the JAVA_HOME
> if JAVA_HOME is not already defined, sets it to jdk home if javac is present else jre
home if java is present.
> if nothing is present, it exits with error
> 
> 
> Diffs
> -----
> 
>   packaging/centos63/cloud-usage.rc 6170379 
>   packaging/debian/init/cloud-usage 1cc75cc 
> 
> Diff: https://reviews.apache.org/r/22721/diff/
> 
> 
> Testing
> -------
> 
> 
> tested it when java is not installed, jre is installed, jdk installed or when a older
version is installed on centos 6.4 and ubuntu 14.04 
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message