Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC45E11E5D for ; Mon, 30 Jun 2014 06:34:06 +0000 (UTC) Received: (qmail 4409 invoked by uid 500); 30 Jun 2014 06:34:06 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 4383 invoked by uid 500); 30 Jun 2014 06:34:06 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 4372 invoked by uid 99); 30 Jun 2014 06:34:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jun 2014 06:34:05 +0000 X-ASF-Spam-Status: No, hits=2.6 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TRACKER_ID X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of Chiradeep.Vittal@citrix.com designates 66.165.176.63 as permitted sender) Received: from [66.165.176.63] (HELO SMTP02.CITRIX.COM) (66.165.176.63) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jun 2014 06:34:03 +0000 X-IronPort-AV: E=Sophos;i="5.01,573,1400025600"; d="scan'208,217";a="148403646" Received: from sjcpex01cl01.citrite.net ([10.216.14.143]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/AES128-SHA; 30 Jun 2014 06:33:35 +0000 Received: from SJCPEX01CL02.citrite.net ([169.254.2.117]) by SJCPEX01CL01.citrite.net ([10.216.14.143]) with mapi id 14.03.0181.006; Sun, 29 Jun 2014 23:33:33 -0700 From: Chiradeep Vittal To: "dev@cloudstack.apache.org" Subject: Re: What to modify to increase instance password length? Thread-Topic: What to modify to increase instance password length? Thread-Index: ZnTifmN83KYrrbRCqy7NSRuh+MRWhrVcpvsAgAABEYCAAAGAgIAAAOEAgAAEcICAAAW7gIAAEZEAgAAIkYD//41JxwAOq/wAAAAJPQAAA9rngAAQNfqAAAE4oIAAvDYpAA== Date: Mon, 30 Jun 2014 06:33:33 +0000 Message-ID: References: <1050158658.2812.1403712979420.JavaMail.zimbra@li.nux.ro> <1390159963.3070.1403718655187.JavaMail.zimbra@li.nux.ro> <1964831912.3455.1403731523532.JavaMail.zimbra@li.nux.ro> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.2.140509 x-originating-ip: [10.13.112.14] Content-Type: multipart/alternative; boundary="_000_CFD652A8488E7chiradeepvittalcitrixcom_" MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org --_000_CFD652A8488E7chiradeepvittalcitrixcom_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Also, to the original question, the password is meant to be temporary =97 y= ou are supposed to login to the vm and change it to whatever standards you = have. From: Harikrishna Patnala > Reply-To: "dev@cloudstack.apache.org" > Date: Wednesday, June 25, 2014 at 10:44 PM To: "dev@cloudstack.apache.org" > Subject: Re: What to modify to increase instance password length? It is better to use ConfigKey class to define configuration parameters, thi= s handles default values in case of NULL or db entry missing and no need to= put in upgrade script. static final ConfigKey CustomDiskOfferingMaxSize =3D new ConfigKey("Advanced", Long.class, "custom.diskoffering.size.max", "1024", "Maximum size in GB for custom disk offering.", true ); More info@ https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configura= tion Thanks Harikrishna On 26-Jun-2014, at 10:39 am, Koushik Das > wrote: Shouldn't the code handle the scenario if vm.password.length is missing fro= m db? In this case the upgrade script will put it but if someone accidental= ly removes it. -----Original Message----- From: Nux! [mailto:nux@li.nux.ro] Sent: Thursday, 26 June 2014 2:55 AM To: dev@cloudstack.apache.org Subject: Re: What to modify to increase instance password length? Wunderbar! Thanks guys! -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro ----- Original Message ----- From: "Daan Hoogland" > To: "dev" > Sent: Wednesday, 25 June, 2014 8:35:00 PM Subject: Re: What to modify to increase instance password length? pulled both On Wed, Jun 25, 2014 at 9:33 PM, Ian Duffy > wrote: Yeah sorry, just noticed and fixed it myself. On 25 June 2014 20:32, Daan Hoogland > wrote: yeah, so I should probably get that one in as well? On Wed, Jun 25, 2014 at 9:28 PM, Ian Duffy > wrote: :( Get them solved? Fixed a styecheck issue in 2bb12f2a85c8497a15cd7b17099aefbd7c486f9b needed to remove unused imports. On 25 June 2014 20:24, Daan Hoogland > wrote: c70cadff0e3d70f625e7160a3aee600a3198cc67 in 4.4 it had conflicts in the sql:( On Wed, Jun 25, 2014 at 8:53 PM, Ian Duffy > wrote: Just pushed a change for this to the 4.4-forward branch. Daan, will you review / cherrypick? 96412e3e58fd1ced9d269e4552aaa6410bedf556 Testing done: Brought up simulator. Changed password flag for the builtin template. Brought up VM, password was displayed at length of 6. Stopped the VM, reset the password, new password was displayed at length of 6. Went into global settings, modified the value for vm.password.length to 20. Restarted the management server. Created a new VM, password was displayed at length of 20. Stopped the VM, reset the password, new password was displayed at length of 20. Thanks, Ian On 25 June 2014 18:50, Nux! > wrote: Volunteer to do it in time for 4.4? Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro ----- Original Message ----- From: "ilya musayev" > To: dev@cloudstack.apache.org Sent: Wednesday, 25 June, 2014 6:30:25 PM Subject: Re: What to modify to increase instance password length? You should ask if this can be done as global setting variable - not hard coded. This should be an easy one. On 6/25/14, 10:14 AM, Nux! wrote: I should submit a bug report to rewrite ACS in a scripting language. Cheers :) -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro ----- Original Message ----- From: "Ian Duffy" > To: "CloudStack Dev" > Sent: Wednesday, 25 June, 2014 6:11:23 PM Subject: Re: What to modify to increase instance password length? Afaik yes. (Will to be corrected on this but it appears to be hard coded) On 25 June 2014 18:06, Nux! > wrote: Thanks, Ian, This means I need to modify the source, rebuild the RPMs and update, right? (ie it's not something that I can just modify on the mgmt server right now). Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro ----- Original Message ----- From: "Ian Duffy" > To: "CloudStack Dev" > Sent: Wednesday, 25 June, 2014 6:02:12 PM Subject: Re: What to modify to increase instance password length? Hi Lucian, Take a look at server/src/com/cloud/server/ManagementServerImpl.java Line 895 - 898 @Override public String generateRandomPassword() { return PasswordGenerator.generateRandomPassword(6); } On 25 June 2014 17:16, Nux! > wrote: Hi guys, Can anyone tell me which changes I should make in order to increase password length for instances? Currently I get something like "tK2yptbby" which might have been secure 10 years ago, but now it's way too short. Thanks! Lucian -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro -- Daan -- Daan -- Daan --_000_CFD652A8488E7chiradeepvittalcitrixcom_--