Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DA7F11B55 for ; Wed, 25 Jun 2014 22:26:50 +0000 (UTC) Received: (qmail 34323 invoked by uid 500); 25 Jun 2014 22:26:49 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 34272 invoked by uid 500); 25 Jun 2014 22:26:49 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 34254 invoked by uid 99); 25 Jun 2014 22:26:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2014 22:26:49 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of mike.tutkowski@solidfire.com designates 209.85.219.52 as permitted sender) Received: from [209.85.219.52] (HELO mail-oa0-f52.google.com) (209.85.219.52) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2014 22:26:46 +0000 Received: by mail-oa0-f52.google.com with SMTP id j17so2933254oag.11 for ; Wed, 25 Jun 2014 15:26:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=uF30G9jWo+e1kC58wcfqnIinUPXCx6wz+v9iiEmUnRA=; b=NedyvgT+OPLmnlxcAWMkMNHVS9KH+xqgwP9z0PbhXwtVLmWZKl+IheTYaD2eDxDj/H IRmuFq52fSSq+QuJR1DjTdZ0A+sWGuHWO7tnHz7KMOsVjaXnPrB1EQvzmlE0TxcBpYrY i42JgpcSaJvCnKZPZ+N6f6qVKJDXt1MGTR12YsFccfG879Br2coUqZ1/+624JTC3gg0j V5h8/I+XczMmoO3tm6gEWiHFA9hIaoegV8DVHs6noKZesXgNqkJR8iVXC0CqZSdNWBfO vzQcjyUfYN+b/vSGg7GRdhZT6H1ObtPM6+SctMxLNnEKNNhdIxWP7A55dSZMUFCZA0Ui UHBg== X-Gm-Message-State: ALoCoQmRZ+UAPRq3QaD3PEOm8suQlzaVfwdM8pf0RJ2zEiPru4SMRP6Bngzpl/PFsm65Fi0As+hx MIME-Version: 1.0 X-Received: by 10.182.98.194 with SMTP id ek2mr11059505obb.5.1403735181309; Wed, 25 Jun 2014 15:26:21 -0700 (PDT) Received: by 10.182.73.197 with HTTP; Wed, 25 Jun 2014 15:26:21 -0700 (PDT) In-Reply-To: References: Date: Wed, 25 Jun 2014 16:26:21 -0600 Message-ID: Subject: Re: [ACS4.4] i18n problems in Add Primary Storage dialog From: Mike Tutkowski To: "dev@cloudstack.apache.org" , vetrivel.chinnasamy@citrix.com Cc: Brian Federle , Alena Prokharchyk , Jessica Wang Content-Type: multipart/alternative; boundary=047d7b2e4206d79c8d04fcb090c3 X-Virus-Checked: Checked by ClamAV on apache.org --047d7b2e4206d79c8d04fcb090c3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable By the way, what I was referring to with my proposed hack was just to fix the two situations ("SR Name-Label" and "Path") by hardcoding the English back in. On Wed, Jun 25, 2014 at 2:34 PM, Mike Tutkowski < mike.tutkowski@solidfire.com> wrote: > It looks like these issues were introduced in > 182c31899bb353eac66a43ca4e81117c4fd06332 by vetrivelc with regards to > externalizing hardcoded strings. > > My guess is that this substitution was done in an automated fashion and > some unintended consequences of the substitution logic occurred. > > vetrivelc - Any chance you could take a look at these issues and decide o= n > a way for us to proceed? This is in 4.4 code (first RC currently planned > for this Friday), so it would be awesome if we could resolve these quickl= y. > > One hack would be for us to just hard code the English words back, but of > course these labels would then be incorrect in other languages (unless, o= f > course, by coincidence the words happened to be the same in each lang). > > Thanks! > > > $form.find('.form-item[rel=3Dpath]').css('display', 'inline-block'); > > var $required =3D > $form.find('.form-item[rel=3Dpath]').find(".name").find("label span"); > > - > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text("Pa= th:").prepend($required); > > + > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text('la= bel.path'+":").prepend($required); > > > > > $form.find('.form-item[rel=3DsmbUsername]').hide(); > > > $form.find('.form-item[rel=3DsmbPassword]').hide(); > > @@ -15414,7 +15414,7 @@ > > > > > $form.find('.form-item[rel=3Dpath]').css('display', 'inline-block'); > > var $required =3D > $form.find('.form-item[rel=3Dpath]').find(".name").find("label span"); > > - > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text("Pa= th:").prepend($required); > > + > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text('la= bel.path'+":").prepend($required); > > > > > $form.find('.form-item[rel=3DsmbUsername]').css('display', 'inline-block'= ); > > > $form.find('.form-item[rel=3DsmbPassword]').css('display', 'inline-block'= ); > > @@ -15441,7 +15441,7 @@ > > > > > $form.find('.form-item[rel=3Dpath]').css('display', 'inline-block'); > > var $required =3D > $form.find('.form-item[rel=3Dpath]').find(".name").find("label span"); > > - > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text("Pa= th:").prepend($required); > > + > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text('la= bel.path'+":").prepend($required); > > > > > $form.find('.form-item[rel=3DsmbUsername]').hide(); > > > $form.find('.form-item[rel=3DsmbPassword]').hide(); > > @@ -15467,7 +15467,7 @@ > > > > > $form.find('.form-item[rel=3Dpath]').css('display', 'inline-block'); > > var $required =3D > $form.find('.form-item[rel=3Dpath]').find(".name").find("label span"); > > - > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text("SR > Name-Label:").prepend($required); > > + > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text(' > label.SR.name'+":").prepend($required); > > > > > $form.find('.form-item[rel=3DsmbUsername]').hide(); > > > $form.find('.form-item[rel=3DsmbPassword]').hide(); > > @@ -15566,7 +15566,7 @@ > > > > > $form.find('.form-item[rel=3Dpath]').css('display', 'inline-block'); > > var $required =3D > $form.find('.form-item[rel=3Dpath]').find(".name").find("label span"); > > - > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text("Pa= th:").prepend($required); > > + > $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text('la= bel.path'+":").prepend($required); > > > On Wed, Jun 25, 2014 at 11:06 AM, Mike Tutkowski < > mike.tutkowski@solidfire.com> wrote: > >> Hi, >> >> I noticed a couple i18n-related issues in the Add Primary Storage dialog= : >> >> 1) label.path shows up literally as label.path (instead of Path) >> >> 2) label.SR.name shows up literally as label.SR.name (instead of SR >> Name-Label) >> >> I looked at the applicable i18n/l10n files and all looked well. >> >> Once I looked in the system.js file, however, I saw the following line >> (with respect to label.SR.name): >> >> $form.find('.form-item[rel=3Dpath]').find(".name").find("label").text(' >> label.SR.name'+":").prepend($required); >> >> There is no i18n lookup here. The same problem exists for label.path >> (only there are more occurrences of that type of code). >> >> I'm not sure why the code was written this way and I'm hoping we can >> resolve this before Friday's first 4.4 RC build. >> >> Any thoughts on this? I've directly CCed a few people who work on the GU= I >> regularly. >> >> Thanks! >> >> -- >> *Mike Tutkowski* >> *Senior CloudStack Developer, SolidFire Inc.* >> e: mike.tutkowski@solidfire.com >> o: 303.746.7302 >> Advancing the way the world uses the cloud >> *=E2=84=A2* >> > > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkowski@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the cloud > *=E2=84=A2* > --=20 *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkowski@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud *=E2=84=A2* --047d7b2e4206d79c8d04fcb090c3--