Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 41A551184C for ; Mon, 30 Jun 2014 18:07:32 +0000 (UTC) Received: (qmail 23256 invoked by uid 500); 30 Jun 2014 18:07:31 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 23214 invoked by uid 500); 30 Jun 2014 18:07:31 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 23201 invoked by uid 99); 30 Jun 2014 18:07:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jun 2014 18:07:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 682CF1DB494; Mon, 30 Jun 2014 18:07:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8365690641143002107==" MIME-Version: 1.0 Subject: Re: Review Request 23168: Update cloudstack-usage JAVA_HOME to find JRE for Java 7 From: "Sebastien Goasguen" To: "Sebastien Goasguen" Cc: "Olivier Lemasle" , "cloudstack" Date: Mon, 30 Jun 2014 18:07:20 -0000 Message-ID: <20140630180720.5201.60004@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sebastien Goasguen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/23168/ X-Sender: "Sebastien Goasguen" References: <20140630155447.5196.32048@reviews.apache.org> In-Reply-To: <20140630155447.5196.32048@reviews.apache.org> Reply-To: "Sebastien Goasguen" X-ReviewRequest-Repository: cloudstack-git --===============8365690641143002107== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23168/#review47000 ----------------------------------------------------------- After the updated review it looks like you are only changing the centOS scripts. What about Ubuntu/debs ? is that already fixed ? - Sebastien Goasguen On June 30, 2014, 3:54 p.m., Olivier Lemasle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23168/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 3:54 p.m.) > > > Review request for cloudstack and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > ------- > > cloudstack-usage is currently configured to search JAVA_HOME only in a small set of paths corresponding to Java 6 (/usr/lib/jvm/java-6-openjdk, /usr/lib/jvm/java-6-openjdk-i386, etc). > > If cloudstack-usage is installed on a server with only Java 7, the service cannot start and fails with the following error: > jsvc error: Cannot locate Java Home > > This commit adds Java 7 paths to the possible set of JAVA_HOME locations. > > > Diffs > ----- > > packaging/centos63/cloud-usage.rc e78f8c1 > > Diff: https://reviews.apache.org/r/23168/diff/ > > > Testing > ------- > > Package CloudStack RPMs for CentOS and install them on a system with java-1.7.0-openjdk and no Java 6 JRE. > Check that cloudstack-usage works correctly. > > > Thanks, > > Olivier Lemasle > > --===============8365690641143002107==--