Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 737AF11301 for ; Fri, 27 Jun 2014 15:46:26 +0000 (UTC) Received: (qmail 10024 invoked by uid 500); 27 Jun 2014 15:46:26 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 9971 invoked by uid 500); 27 Jun 2014 15:46:25 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 9955 invoked by uid 99); 27 Jun 2014 15:46:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 15:46:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5B0C1DB40C; Fri, 27 Jun 2014 15:46:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1507301129703733850==" MIME-Version: 1.0 Subject: Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935 introduces the NullPointerException in ZoneWideStorageAllocator filter method From: "ASF Subversion and Git Services" To: "Rajesh Battala" , "Sateesh Chodapuneedi" , "Devdeep Singh" Cc: "ASF Subversion and Git Services" , "Anshul Gangwar" , "cloudstack" Date: Fri, 27 Jun 2014 15:46:14 -0000 Message-ID: <20140627154614.22595.71638@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/22807/ X-Sender: "ASF Subversion and Git Services" References: <20140623053034.22596.59908@reviews.apache.org> In-Reply-To: <20140623053034.22596.59908@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============1507301129703733850== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22807/#review46868 ----------------------------------------------------------- Commit 80f2694443e2795f289c95b10776285cc449f779 in cloudstack's branch refs/heads/4.4 from Daan Hoogland [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=80f2694 ] Revert "CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic" This reverts commit 99dd86e588fd28dedd5fb3b830297a8a4f885760. - ASF Subversion and Git Services On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22807/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 5:30 a.m.) > > > Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi. > > > Bugs: CLOUDSTACK-6965 > https://issues.apache.org/jira/browse/CLOUDSTACK-6965 > > > Repository: cloudstack-git > > > Description > ------- > > Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's filter method has been removed it is using AbstractStoragePoolAllocator's filter method. > In the filter method there is check for cluster's hypervisor type and and disk profile hypervisor type. > But cluster is null for ZoneWideStoragePool and Hence the exception. > > > Diffs > ----- > > engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java 2d958a6 > > Diff: https://reviews.apache.org/r/22807/diff/ > > > Testing > ------- > > > Thanks, > > Anshul Gangwar > > --===============1507301129703733850==--