Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============2798383775666488504=="
MIME-Version: 1.0
Subject: Re: Review Request 22934: CLOUDSTACK-6984: Fixing few issues found
 durign
 simulator run
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Girish Shilamkar" <girish@clogeny.com>
Cc: "Gaurav Aradhye" <gaurav.aradhye@clogeny.com>,
 "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 24 Jun 2014 15:24:53 -0000
Message-ID: <20140624152453.22595.35465@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20140624150446.22595.78930@reviews.apache.org>
In-Reply-To: <20140624150446.22595.78930@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============2798383775666488504==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22934/#review46532
-----------------------------------------------------------


Commit 0df156c09e152845d6c6332fa1d91fe9c15c7cc6 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0df156c ]

CLOUDSTACK-6984: Resolving issues found during simulator run


- ASF Subversion and Git Services


On June 24, 2014, 3:04 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22934/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 3:04 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-6984
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6984
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing issues found in simulator run.
> 
> 1. test_01_stop_vm failed on simulator because of escape sequences present in the response from simulator
> 2. test_releaseIP failed due to incorrect listing of IP address. The IP address which was was associated was not listed exactly (Listed by passing account id and domain id which listed other IP addresses associated with the account along with desired IP). The IP address which is not used for source nat should get listed instead.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_network.py 0ae777e 
>   test/integration/smoke/test_vm_life_cycle.py 9ab7848 
>   tools/marvin/marvin/lib/base.py c3d98c9 
> 
> Diff: https://reviews.apache.org/r/22934/diff/
> 
> 
> Testing
> -------
> 
> yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


--===============2798383775666488504==--