Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============6920475008507306652=="
MIME-Version: 1.0
Subject: Re: Review Request 22256: CLOUDSTACK-6830 :[hyper-v] fixed vm
 migration
 failing between different clusters if volumes are on zone wide primary store
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Rajesh Battala" <rajesh.battala@citrix.com>,
 "Sateesh Chodapuneedi" <sateesh.chodapuneedi@citrix.com>,
 "Devdeep Singh" <devdeep.singh@citrix.com>
Cc: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "Anshul Gangwar" <anshul.gangwar@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Mon, 23 Jun 2014 07:56:29 -0000
Message-ID: <20140623075629.22596.30332@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20140620102127.6311.16949@reviews.apache.org>
In-Reply-To: <20140620102127.6311.16949@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============6920475008507306652==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22256/#review46388
-----------------------------------------------------------


Commit af37ade9e3ff4c686883b2218e309c30b2d192ac in cloudstack's branch refs/heads/4.4 from Anshul Gangwar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=af37ade ]

CLOUDSTACK-6830: Fixed [hyper-v] during VM migration, volumes on zone wide primary
store requires storage migration resulting in failure of VM migration. This also
improves the hostsformigration api. Firstly we were trying to list all hosts and
then finding suitable storage pools for all volumes and then we were checking
whether vm migration requires storage migration to that host. Now the process is
updated. We are checking for only those volumes which are not in zone wide primary
store. We are verifying by comparing volumes->poolid->clusterid to host clusterid.
If it uses local or clusterids are different then verifying whether host has
suitable storage pools for the volume of the vm to be migrated too.

(cherry picked from commit 64153a43711420224655bfbe248b4b87474a1f23)

Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java


- ASF Subversion and Git Services


On June 20, 2014, 10:21 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22256/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 10:21 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-6830
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6830
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed vm migration failing between different clusters if volumes are on zone primary store. During VM migration, volumes on zone wide primary store requiring storage migration resulting in failure of VM migration
>     
>     This also improves the hostsformigration api. Firstly we were ttrying to list all hosts and then finding suitable storage pools for all volumes
>     and then we were checking for whether vm migration requires storage migration
>     Now the process is reversed, We are checking for only those volumes which are not in zone wide primary store and only verifying
>     that volumes->poolid->clusterid is different from host clusterid and usesLocal then only it requires storage migration
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4502365 
>   server/src/com/cloud/server/ManagementServerImpl.java dd4ce0f 
> 
> Diff: https://reviews.apache.org/r/22256/diff/
> 
> 
> Testing
> -------
> 
> tested following scenarios on my local setup.
> 1. VM migration for volumes on zone wide primary store is working fine
> 2. VM migration for volumes on cluster wide primary store is working fine
> 3. VM migration for volumes on local storage is working fine
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


--===============6920475008507306652==--