Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 270F411681 for ; Mon, 23 Jun 2014 05:23:51 +0000 (UTC) Received: (qmail 59846 invoked by uid 500); 23 Jun 2014 05:23:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 59800 invoked by uid 500); 23 Jun 2014 05:23:49 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 59785 invoked by uid 99); 23 Jun 2014 05:23:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 05:23:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2A8E11DB1CA; Mon, 23 Jun 2014 05:23:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3072594306751063472==" MIME-Version: 1.0 Subject: Re: Review Request 22859: Fixed Resource Leaks reported by coverity From: "daan Hoogland" To: "daan Hoogland" Cc: "Santhosh Edukulla" , "cloudstack" Date: Mon, 23 Jun 2014 05:23:39 -0000 Message-ID: <20140623052339.22596.29957@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/22859/ X-Sender: "daan Hoogland" References: <20140623045926.22603.85519@reviews.apache.org> In-Reply-To: <20140623045926.22603.85519@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============3072594306751063472== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22859/#review46381 ----------------------------------------------------------- engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java please be more verbose. An operator without java skills is not helped with this message - daan Hoogland On June 23, 2014, 4:59 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22859/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 4:59 a.m.) > > > Review request for cloudstack and daan Hoogland. > > > Bugs: coverity > https://issues.apache.org/jira/browse/coverity > > > Repository: cloudstack-git > > > Description > ------- > > fixed resource leaks reported by coverity > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java 836a537 > framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java 4cee081 > framework/db/src/com/cloud/utils/db/ScriptRunner.java 932b37b > framework/jobs/src/org/apache/cloudstack/framework/jobs/dao/AsyncJobJoinMapDaoImpl.java 7bc29db > > Diff: https://reviews.apache.org/r/22859/diff/ > > > Testing > ------- > > Post the changes, built the code and ran a deploy Datacenter. > > > Thanks, > > Santhosh Edukulla > > --===============3072594306751063472==--