Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 55DAE11EAF for ; Fri, 20 Jun 2014 10:02:35 +0000 (UTC) Received: (qmail 29435 invoked by uid 500); 20 Jun 2014 10:02:34 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 29394 invoked by uid 500); 20 Jun 2014 10:02:34 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 29381 invoked by uid 99); 20 Jun 2014 10:02:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jun 2014 10:02:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 53EF81D9602; Fri, 20 Jun 2014 10:02:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3514605184776521170==" MIME-Version: 1.0 Subject: Re: Review Request 22727: CLOUDSTACK-6847 . Link.java and ConsoleProxySecureServerFactoryImpl.java have hardcoded value From: "upendra moturi" To: "daan Hoogland" Cc: "upendra moturi" , "cloudstack" Date: Fri, 20 Jun 2014 10:02:24 -0000 Message-ID: <20140620100224.6311.34880@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "upendra moturi" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/22727/ X-Sender: "upendra moturi" References: <20140620100132.6311.97232@reviews.apache.org> In-Reply-To: <20140620100132.6311.97232@reviews.apache.org> Reply-To: "upendra moturi" X-ReviewRequest-Repository: cloudstack-git --===============3514605184776521170== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22727/ ----------------------------------------------------------- (Updated June 20, 2014, 10:02 a.m.) Review request for cloudstack and daan Hoogland. Bugs: CLOUDSTACK-6847 https://issues.apache.org/jira/browse/CLOUDSTACK-6847 Repository: cloudstack-git Description ------- CLOUDSTACK-6847.Link.java and ConsoleProxySecureServerFactoryImpl.java have hardcoded value "vmops.com" which is used as a passphrase for keystore (cloud.keystore). It mean when generating jks file from certs we need to use this as passphrase. Changed the code to get those values form properties file. Changed all files to my knowledge . Diffs ----- client/tomcatconf/db.properties.in b224cec services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxySecureServerFactoryImpl.java 81d623a setup/bindir/cloud-setup-encryption.in cf27b37 utils/src/com/cloud/utils/nio/Link.java 0767815 Diff: https://reviews.apache.org/r/22727/diff/ Testing ------- Did basic testing. Thanks, upendra moturi --===============3514605184776521170==--