Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============3678182207327132905=="
MIME-Version: 1.0
Subject: Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template
 from a
 VM in Simulator results in incorrect size
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "daan Hoogland" <daan.hoogland@gmail.com>,
 "Prasanna Santhanam" <tsp@apache.org>
Cc: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "Girish Chaudhari" <girish.chaudhari@sungard.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 17 Jun 2014 11:49:29 -0000
Message-ID: <20140617114929.6311.81454@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20140617093712.13794.82343@reviews.apache.org>
In-Reply-To: <20140617093712.13794.82343@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============3678182207327132905==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45931
-----------------------------------------------------------


Commit 5cc5483a7895e7876e336349323a5ea5598d5137 in cloudstack's branch refs/heads/4.4 from Girish chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5cc5483 ]

CLOUDSTACK-5150 - set the template size from source

Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit 883d8f11196e9ca55324bcf075880e077a2d3df3)


- ASF Subversion and Git Services


On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 9:37 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-5150
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5150
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException. 
> Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue. 
> Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87 
> 
> Diff: https://reviews.apache.org/r/19779/diff/
> 
> 
> Testing
> -------
> 
> Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>


--===============3678182207327132905==--