Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F948115AA for ; Mon, 16 Jun 2014 12:17:33 +0000 (UTC) Received: (qmail 23744 invoked by uid 500); 16 Jun 2014 12:17:32 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 23700 invoked by uid 500); 16 Jun 2014 12:17:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 23685 invoked by uid 99); 16 Jun 2014 12:17:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2014 12:17:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 53A521D9FA6; Mon, 16 Jun 2014 12:17:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5435618671818552323==" MIME-Version: 1.0 Subject: Re: Review Request 22525: Fixed few reported resource leak issues From: "daan Hoogland" To: "daan Hoogland" Cc: "Santhosh Edukulla" , "cloudstack" Date: Mon, 16 Jun 2014 12:17:22 -0000 Message-ID: <20140616121722.6311.26417@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/22525/ X-Sender: "daan Hoogland" References: <20140613063533.22324.76620@reviews.apache.org> In-Reply-To: <20140613063533.22324.76620@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============5435618671818552323== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22525/#review45741 ----------------------------------------------------------- engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java as said before, i think TransactionLegacy must become Closable otherwise it seems ok, test compiling before applying - daan Hoogland On June 13, 2014, 6:35 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22525/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 6:35 a.m.) > > > Review request for cloudstack and daan Hoogland. > > > Repository: cloudstack-git > > > Description > ------- > > Fixed few coverity issues reported. > > > Diffs > ----- > > engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java f72690e > > Diff: https://reviews.apache.org/r/22525/diff/ > > > Testing > ------- > > Built the CS, ran deploy data center post the change. > > > Thanks, > > Santhosh Edukulla > > --===============5435618671818552323==--