Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============0895990556653994844=="
MIME-Version: 1.0
Subject: Re: Review Request 22554: CLOUDSTACK-6909 - fix marvin's handling of
 SMB
 credentials for storage
From: "Santhosh Edukulla" <santhosh.edukulla@citrix.com>
To: "Santhosh Edukulla" <santhosh.edukulla@citrix.com>,
 "John Dilley" <john.dilley@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Fri, 13 Jun 2014 09:35:11 -0000
Message-ID: <20140613093511.22323.59449@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Santhosh Edukulla" <noreply@reviews.apache.org>
References: <20140613091729.22323.5459@reviews.apache.org>
In-Reply-To: <20140613091729.22323.5459@reviews.apache.org>
Reply-To: "Santhosh Edukulla" <santhosh.edukulla@citrix.com>

--===============0895990556653994844==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22554/#review45598
-----------------------------------------------------------


tools/marvin/marvin/deployDataCenter.py
<https://reviews.apache.org/r/22554/#comment80484>

    Just use "in" instead


- Santhosh Edukulla


On June 13, 2014, 9:17 a.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22554/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 9:17 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6909
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6909
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix marvin's handling of details field for primary and secondary storage to cope with SMB credentials. This allows Hyper-V to work.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/deployDataCenter.py 22b78ab 
> 
> Diff: https://reviews.apache.org/r/22554/diff/
> 
> 
> Testing
> -------
> 
> Tested deploydataCenter with this JSON:
> 
> {
>    "dbSvr":{
>       "dbSvr":"10.220.137.39",
>       "passwd":"cloud",
>       "db":"cloud",
>       "port":3306,
>       "user":"cloud"
>    },
>    "zones":[
>       {
>          "name":"XenRT-Zone-0",
>          "guestcidraddress":"192.168.200.0/24",
>          "dns1":"10.220.160.11",
>          "physical_networks":[
>             {
>                "XRT_VLANRangeSize":10,
>                "name":"AdvPhyNetwork",
>                "providers":[
>                   {
>                      "broadcastdomainrange":"ZONE",
>                      "name":"VirtualRouter"
>                   },
>                   {
>                      "broadcastdomainrange":"ZONE",
>                      "name":"VpcVirtualRouter"
>                   },
>                   {
>                      "broadcastdomainrange":"ZONE",
>                      "name":"InternalLbVm"
>                   }
>                ],
>                "broadcastdomainrange":"Zone",
>                "vlan":"3000-3009",
>                "traffictypes":[
>                   {
>                      "typ":"Guest"
>                   },
>                   {
>                      "typ":"Management"
>                   },
>                   {
>                      "typ":"Public"
>                   }
>                ],
>                "isolationmethods":[
>                   "VLAN"
>                ]
>             }
>          ],
>          "ipranges":[
>             {
>                "startip":"10.220.164.0",
>                "endip":"10.220.164.9",
>                "netmask":"255.255.240.0",
>                "XRT_GuestIPRangeSize":10,
>                "gateway":"10.220.160.1"
>             }
>          ],
>          "networktype":"Advanced",
>          "pods":[
>             {
>                "XRT_PodIPRangeSize":10,
>                "name":"XenRT-Zone-0-Pod-0",
>                "endip":"10.220.164.39",
>                "startip":"10.220.164.30",
>                "netmask":"255.255.240.0",
>                "clusters":[
>                   {
>                      "XRT_HyperVHostIds":"0",
>                      "clustername":"XenRT-Zone-0-Pod-0-Cluster-0",
>                      "hypervisor":"hyperv",
>                      "primaryStorages":[
>                         {
>                            "url":"cifs://10.220.163.45/storage/primary",
>                            "name":"XenRT-Zone-0-Pod-0-Primary-Store",
>                            "details":[
>                               {
>                                  "user":"Administrator"
>                               },
>                               {
>                                  "password":"xenroot01T"
>                               },
>                               {
>                                  "domain":"XSQA"
>                               }
>                            ]
>                         }
>                      ],
>                      "clustertype":"CloudManaged",
>                      "hosts":[
>                         {
>                            "url":"http://10.220.163.45",
>                            "username":"root",
>                            "password":"xenroot"
>                         }
>                      ],
>                      "XRT_Hosts":1
>                   }
>                ],
>                "gateway":"10.220.160.1"
>             }
>          ],
>          "internaldns1":"10.220.160.11",
>          "secondaryStorages":[
>             {
>                "url":"cifs://10.220.163.45/storage/secondary",
>                "details":{
>                   "domain":"XSQA",
>                   "password":"xenroot01T",
>                   "user":"Administrator"
>                },
>                "provider":"SMB"
>             }
>          ]
>       }
>    ],
>    "mgtSvr":[
>       {
>          "mgtSvrIp":"10.220.137.39",
>          "passwd":"xenroot",
>          "port":8096,
>          "user":"root"
>       }
>    ]
> }
> 
> 
> Thanks,
> 
> John Dilley
> 
>


--===============0895990556653994844==--