Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 884AF11DAF for ; Sun, 8 Jun 2014 18:32:53 +0000 (UTC) Received: (qmail 9254 invoked by uid 500); 8 Jun 2014 18:32:53 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 9203 invoked by uid 500); 8 Jun 2014 18:32:53 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 9190 invoked by uid 99); 8 Jun 2014 18:32:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Jun 2014 18:32:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ED7451C0C1C; Sun, 8 Jun 2014 18:32:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2239994393282698195==" MIME-Version: 1.0 Subject: Review Request 22356: Fixed few coverity issues reported From: "Santhosh Edukulla" To: "daan Hoogland" Cc: "Santhosh Edukulla" , "cloudstack" Date: Sun, 08 Jun 2014 18:32:43 -0000 Message-ID: <20140608183243.22322.79422@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Santhosh Edukulla" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/22356/ X-Sender: "Santhosh Edukulla" Reply-To: "Santhosh Edukulla" X-ReviewRequest-Repository: cloudstack-git --===============2239994393282698195== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22356/ ----------------------------------------------------------- Review request for cloudstack and daan Hoogland. Repository: cloudstack-git Description ------- Fixed few coverity issues reported for resource leak, value comparison, invalid loop check for result set. Diffs ----- engine/schema/src/com/cloud/upgrade/DatabaseCreator.java 91ef318 engine/schema/src/com/cloud/upgrade/DatabaseIntegrityChecker.java c20a418 engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 0761c9f framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java 58584f9 framework/db/src/com/cloud/utils/db/Merovingian2.java 6eeea9f framework/db/src/com/cloud/utils/db/ScriptRunner.java 6614527 framework/db/src/com/cloud/utils/db/TransactionLegacy.java ac0ea21 server/src/com/cloud/test/IPRangeConfig.java 1d56471 usage/src/com/cloud/usage/UsageSanityChecker.java 5e6123b utils/src/com/cloud/utils/crypt/EncryptionSecretKeySender.java 086e8a8 Diff: https://reviews.apache.org/r/22356/diff/ Testing ------- 1.Built the code and found no issues. 2.Built the simulator and ran a deploy datacenter with the changes. Thanks, Santhosh Edukulla --===============2239994393282698195==--