Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA3FB116F8 for ; Wed, 4 Jun 2014 14:49:58 +0000 (UTC) Received: (qmail 21728 invoked by uid 500); 4 Jun 2014 14:49:58 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 21684 invoked by uid 500); 4 Jun 2014 14:49:58 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 21672 invoked by uid 99); 4 Jun 2014 14:49:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2014 14:49:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 52C711D93EB; Wed, 4 Jun 2014 14:49:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5233458596605958399==" MIME-Version: 1.0 Subject: Re: Review Request 21908: Fix for CLOUDSTACK-6464 From: "ASF Subversion and Git Services" To: ASF Subversion and Git Services , =?utf-8?q?Anders_Lannerb=C3=A4ck?= , cloudstack Date: Wed, 04 Jun 2014 14:49:49 -0000 Message-ID: <20140604144949.12449.97177@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/21908/ X-Sender: "ASF Subversion and Git Services" References: <20140526122509.12586.71048@reviews.apache.org> In-Reply-To: <20140526122509.12586.71048@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============5233458596605958399== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21908/#review44713 ----------------------------------------------------------- Commit 91391e6779bd25b91a3ca4d014656e24592187eb in cloudstack's branch refs/heads/4.4 from Edison Su [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91391e6 ] CLOUDSTACK-6464: if guest network type is vlan://untagged, and traffic label is used, kvm agent needs to honor traffic label (cherry picked from commit dfb59cd6cc0292a88cb619e53f34cdb713879ffd) - ASF Subversion and Git Services On May 26, 2014, 12:25 p.m., Anders Lannerbäck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21908/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 12:25 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Fix for CLOUDSTACK-6464. This patch is against 4.3-branch. > > The original code adds broadcastUri on the format "vlan://100", but later looks for HashMap keys without the "vlan://" bit. This causes new interfaces be created with duplicate MACs and the routers become unusable. > > > Diffs > ----- > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 36382e3 > > Diff: https://reviews.apache.org/r/21908/diff/ > > > Testing > ------- > > Used to repair our production Cloudstack instance. > > > Thanks, > > Anders Lannerbäck > > --===============5233458596605958399==--