Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B9D9D11793 for ; Tue, 3 Jun 2014 07:22:40 +0000 (UTC) Received: (qmail 94698 invoked by uid 500); 3 Jun 2014 07:22:38 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 94617 invoked by uid 500); 3 Jun 2014 07:22:38 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 94546 invoked by uid 99); 3 Jun 2014 07:22:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2014 07:22:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 065B31D7636; Tue, 3 Jun 2014 07:22:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3449256022794586927==" MIME-Version: 1.0 Subject: Re: Review Request 22193: Fixed ResourceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity From: "Hugo Trippaers" To: "daan Hoogland" , "Abhinandan Prateek" Cc: "Rajani Karuturi" , "Hugo Trippaers" , "cloudstack" Date: Tue, 03 Jun 2014 07:22:29 -0000 Message-ID: <20140603072229.12452.89585@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Hugo Trippaers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/22193/ X-Sender: "Hugo Trippaers" References: <20140603072007.12449.69976@reviews.apache.org> In-Reply-To: <20140603072007.12449.69976@reviews.apache.org> Reply-To: "Hugo Trippaers" X-ReviewRequest-Repository: cloudstack-git --===============3449256022794586927== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On June 3, 2014, 7:20 a.m., Hugo Trippaers wrote: > > master: > > commit 2424d9a9e0f1189044303a98c40e60033808f0b2 > > Author: Rajani Karuturi > > Date: Tue Jun 3 12:31:20 2014 +0530 > > > > Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity > > > > Signed-off-by: Hugo Trippaers > > > > > > 4.4-forward: > > commit 67d92726cb4b0b195804fb8a3e3c76f9a2341b39 > > Author: Rajani Karuturi > > Date: Tue Jun 3 12:31:20 2014 +0530 > > > > Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity > > > > Signed-off-by: Hugo Trippaers > > > > Cherry-picked to release branch - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22193/#review44603 ----------------------------------------------------------- On June 3, 2014, 7:07 a.m., Rajani Karuturi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22193/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 7:07 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and daan Hoogland. > > > Repository: cloudstack-git > > > Description > ------- > > The issue is reported by coverity scan @ https://scan.coverity.com/projects/943 > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java da71d44 > > Diff: https://reviews.apache.org/r/22193/diff/ > > > Testing > ------- > > > Thanks, > > Rajani Karuturi > > --===============3449256022794586927==--