Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6855A116BD for ; Mon, 2 Jun 2014 08:21:14 +0000 (UTC) Received: (qmail 73208 invoked by uid 500); 2 Jun 2014 08:21:14 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 73158 invoked by uid 500); 2 Jun 2014 08:21:14 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 73145 invoked by uid 99); 2 Jun 2014 08:21:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jun 2014 08:21:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1CC581C96AA; Mon, 2 Jun 2014 08:21:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1188783559886881971==" MIME-Version: 1.0 Subject: Re: Review Request 22093: VPC's VR missing public NIC eth1 From: "Joris van Lieshout" To: "Marcus Sorensen" Cc: "Joris van Lieshout" , "daan Hoogland" , "cloudstack" Date: Mon, 02 Jun 2014 08:21:05 -0000 Message-ID: <20140602082105.12449.24052@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joris van Lieshout" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/22093/ X-Sender: "Joris van Lieshout" References: <20140530210024.12586.75981@reviews.apache.org> In-Reply-To: <20140530210024.12586.75981@reviews.apache.org> Reply-To: "Joris van Lieshout" X-ReviewRequest-Repository: cloudstack-git --===============1188783559886881971== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22093/#review44479 ----------------------------------------------------------- The issue I see with this fix is that it also applies to other hypvervisors and, as far as I know, this is not broken on, at least, XenServer. Thorough testing will be required. - Joris van Lieshout On May 30, 2014, 9 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22093/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 9 p.m.) > > > Review request for cloudstack and Marcus Sorensen. > > > Repository: cloudstack-git > > > Description > ------- > > VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132 > > Diff: https://reviews.apache.org/r/22093/diff/ > > > Testing > ------- > > > Thanks, > > daan Hoogland > > --===============1188783559886881971==--