cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kelven Yang <kelven.y...@citrix.com>
Subject Re: unused private methods in VirtualMachinManagerImpl
Date Tue, 10 Jun 2014 23:13:00 GMT
The usage of these private methods are through reflection, making it
private is to avoid exposing unnecessary internal structures to outside.

Kelven

On 6/10/14, 2:46 AM, "Rajani Karuturi" <Rajani.Karuturi@citrix.com> wrote:

>Hi Kelven,
>while fixing some of the issues reported by coverity I encountered some
>unused private methods in VirtualMachineManagerImpl.java
>(https://reviews.apache.org/r/22364 ) and removed them. Koushik pointed
>that they are getting used by the job framework.
>Looks like these are used by the job framework by making them public
>through reflection and following some convention for the function names.
>
>Its very difficult to find the usages or refactor which can have some
>unforeseen consequences.
>
>Can you share some details about them? probably some javadoc?
>
>
>~Rajani
>
>
>
>On 10-Jun-2014, at 12:37 pm, Koushik Das <koushik.das@citrix.com> wrote:
>
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22364/#review45200
>> -----------------------------------------------------------
>> 
>> 
>> 
>> engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
>> <https://reviews.apache.org/r/22364/#comment79921>
>> 
>>    These methods are getting used by the job framework. Check
>>handleVmWorkJob() method in the same java file.
>> 
>> 
>> - Koushik Das
>> 
>> 
>> On June 10, 2014, 4:06 a.m., Rajani Karuturi wrote:
>>> 
>>> -----------------------------------------------------------
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/22364/
>>> -----------------------------------------------------------
>>> 
>>> (Updated June 10, 2014, 4:06 a.m.)
>>> 
>>> 
>>> Review request for cloudstack, daan Hoogland, Kelven Yang, Koushik
>>>Das, and Santhosh Edukulla.
>>> 
>>> 
>>> Repository: cloudstack-git
>>> 
>>> 
>>> Description
>>> -------
>>> 
>>> NPEs, unused code or dead code, unwritten field access and self
>>>assignment
>>> 
>>> 
>>> Diffs
>>> -----
>>> 
>>>  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
>>>25c67db 
>>> 
>>> Diff: https://reviews.apache.org/r/22364/diff/
>>> 
>>> 
>>> Testing
>>> -------
>>> 
>>> 
>>> Thanks,
>>> 
>>> Rajani Karuturi
>>> 
>>> 
>> 
>


Mime
View raw message