cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject [DISCUSS] try-with-resouce use
Date Fri, 06 Jun 2014 20:22:34 GMT
H,

I have commited a patch to Upgrade430to440.java that removes all
close() calls on PreparedStament en ResultSet objects, replacing it
with the try(<resouce>) construct in java 7. I was tempted for a short
moment to back-port it to older Upgrade classes. As those upgrade
paths are to be supported by lower versions of java. In master (and
branch 4.4) however these are only to be run with java 7. So should we
fix the upgrades by try-with-resources or not?

-- 
Daan

Mime
View raw message