cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Tutkowski <mike.tutkow...@solidfire.com>
Subject Re: [ACS4.4, 4.4-forward] Please revert commit
Date Fri, 27 Jun 2014 06:19:24 GMT
Yeah, I just looked at the Review Request:

https://reviews.apache.org/r/22717/#review46838

It says it's for master (4.5), so I'm not sure how this ended up in 4.4 or
4.4-forward.


On Fri, Jun 27, 2014 at 12:09 AM, Mike Tutkowski <
mike.tutkowski@solidfire.com> wrote:

> Hi Daan,
>
> Please revert commit 99dd86e588fd28dedd5fb3b830297a8a4f885760 from 4.4.
>
> Also, please revert commit 45f0c7367680f4bfbcee470139b708d69322be78 from
> 4.4-forward.
>
> These commits actually break zone-wide primary storage.
>
> I was not aware that they ended up in 4.4 and 4.4-forward (I was thinking
> they were just in master).
>
> I performed some testing on this logic in master tonight and saw the
> breakage of zone-wide primary storage.
>
> In my opinion, we don't have enough in the way of regression testing in
> CloudStack to be comfortable committing code that can have such
> wide-ranging effects this late in the game.
>
> I think we should start asking for a risk analysis from the developer when
> code is checked in this late in the game (the more risk, the more important
> the issue better be and the more testing that better have been done). In
> this case, my entire plug-in would have been rendered useless in 4.4 by
> these checkins and I don't understand how the issue itself even qualified
> as a Blocker or Critical.
>
> Thanks, Daan!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message