cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prachi Damle <>
Subject RE: Need to revert CLOUDSTACK-5853
Date Fri, 06 Jun 2014 23:14:02 GMT
Hi Marcus,

I have reopened this ticket for 4.4 release, fix needed for this is reverting the code added
as part of this in earlier versions.


-----Original Message-----
From: Prachi Damle [] 
Sent: Wednesday, June 04, 2014 1:04 PM
To: Marcus
Subject: Need to revert CLOUDSTACK-5853

Hi Marcus,

This is regarding bug fix:
I see that as a fix, in ClusterScopeStoragePoolAllocator we remove the storage pools from
avoid set if they happen to match the tag but are found in avoid set.

However this fix is not correct since it breaks the design of avoid set. A storage pool might
be put in the 'avoid' set by the calling logic for a valid reason like capacity exceeded or
creation of disks failed on previous try etc.
In such cases the fix will override the avoid set and keep on trying the same pool.

So will it be possible for you to revert

The correct way to fix this is handling of the avoid set in the caller of the StoragePoolAllocator
- in most of the VM operations the caller is the DeploymentPlanningManager.
I had already added the necessary fix in DeploymentPlanningManager  through this ticket


View raw message