cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 22807: CLOUDSTACK-6965: Fix for CLOUDSTACK-6935 introduces the NullPointerException in ZoneWideStorageAllocator filter method
Date Fri, 27 Jun 2014 15:46:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22807/#review46868
-----------------------------------------------------------


Commit 80f2694443e2795f289c95b10776285cc449f779 in cloudstack's branch refs/heads/4.4 from
Daan Hoogland
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=80f2694 ]

Revert "CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic"

This reverts commit 99dd86e588fd28dedd5fb3b830297a8a4f885760.


- ASF Subversion and Git Services


On June 23, 2014, 5:30 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22807/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 5:30 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-6965
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6965
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for CLOUDSTACK-6935 has introduced the NullPointerException in code. Since ZoneWideStoragePoolAllocator's
filter method has been removed it is using AbstractStoragePoolAllocator's filter method.
> In the filter method there is check for cluster's hypervisor type and and disk profile
hypervisor type.
> But cluster is null for ZoneWideStoragePool and Hence the exception.
> 
> 
> Diffs
> -----
> 
>   engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
2d958a6 
> 
> Diff: https://reviews.apache.org/r/22807/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message