cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yoshikazu Nojima" <m...@ynojima.net>
Subject Re: Review Request 22717: refactor StoragePoolAllocator#filter logic
Date Fri, 27 Jun 2014 06:33:44 GMT


> On June 27, 2014, 5:46 a.m., Mike Tutkowski wrote:
> > I first had a chance to run this patch through a sophisticated test tonight and
noticed an issue with zone-wide primary storage that's based on the iSCSI protocol.
> > 
> > This patch leads to iSCSI storage being filtered out for ROOT volumes, which is
a legitimate use case in my scenario.
> > 
> > As such, I had to return the filter method to the ZoneWideStoragePoolAllocator class.
> > 
> > I left in the other modification to the AbstractStoragePoolAllocator.

I thought the root volume filtering logic weird, but I didn't dig into the problem.
Since this is a good opportunity, I would like to rethink this logic.
which storage requires the root volume filtering logic?
I understand that SolidFire's storage doesn't require it, but what about other iSCSI storage?
Is there any reason that other iSCSI storage cannot handle a root volume? Does anyone know?
Even if SolidFire's storage is the only iSCSI storage that can handle a root volume, I think
SolidFire's storage should be exempted from the filtering logic not because storage is zone
wide, but because storage is SolidFire's.


- Yoshikazu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22717/#review46838
-----------------------------------------------------------


On June 18, 2014, 6:10 a.m., Yoshikazu Nojima wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22717/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 6:10 a.m.)
> 
> 
> Review request for cloudstack, Mike Tutkowski and Prachi Damle.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> refactor StoragePoolAllocator#filter logic to enable hypervisor type check, storage type
check for root volume and avoid list check, and to support IOPS capacity control in a cluster
wide storage pool and a local storage pool.
> 
> 
> Diffs
> -----
> 
>   engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
ddbb5a4 
>   engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java
8fb9c8d 
> 
> Diff: https://reviews.apache.org/r/22717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yoshikazu Nojima
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message