cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC
Date Thu, 19 Jun 2014 06:28:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22692/#review46190
-----------------------------------------------------------



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81464>

    Move it inside the else block.



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81465>

    Is the account created?



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81466>

    Does this user already exists?



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81461>

    Please dont add assert in setup, instead please use raising exceptions.



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81462>

    Does this required to be cleaned up?



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81467>

    Move it immediately after it is created or acquired, in between if some thing happens,
in exception clean will be called but account wont be deleted.



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81463>

    Do we want to delete existing vpc offering as well, or delete the one we created? That
is move this cleanup inside else?



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81468>

    is this cleaned?



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81469>

    Call cleanup in case of exceptions.



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81470>

    just set the self.cleanup back to empty.



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81459>

    We defined a new value intervlan, when to use this value explicitly?



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81460>

    documenting\writing steps as part of test cases are good!



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81472>

    No Assertions or failures, only exceptions? Please use assertions or failures for determining
product failures rather exceptions.



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81471>

    This should be == comparison.



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81456>

    Check the object name?



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81457>

    Covert to lower chars and check. EX: "Device not found".lower() in "abc".lower()
    



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81458>

    There are no fails\asserts, so raising exception is considered to be failed? If so, please
use explicit self.fail, raising exception inside the test code is a test code error, but explicit
calling fail has to be a product failure



test/integration/component/test_remotevpn_vpc.py
<https://reviews.apache.org/r/22692/#comment81455>

    Check the spelling, I believe this has to be exception, not ex'p'ection"


- Santhosh Edukulla


On June 19, 2014, 6:02 a.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22692/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 6:02 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Raja Pullela, sangeetha hariharan, sanjeev
n, Santhosh Edukulla, sudha ponnaganti, SrikanteswaraRao Talluri, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test Suite for Testing Remote Access VPN on VPC. 
> 
> I successfully automated the following components:
> 
> 1.VPN Client Installation on Linux
> 2.Component that efficiently verifies Remote VPN Access between client and the Server.
> 3.Developed a component that automates VPN Client Configuration and services.
> 4.Test Cases of the Feature
> 5.Tested the Code multiple times on XenServer and fixed the bugs.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py d870c98 
> 
> Diff: https://reviews.apache.org/r/22692/diff/
> 
> 
> Testing
> -------
> 
> Test case no : Enable VPN for Public IP Address on the VPC ... === TestName: test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM
| Status : SUCCESS ===
> ok
> Test case no : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser | Status
: SUCCESS ===
> ok
> Test case no : Add a Different VPN User and Test Access with already existing VPN User
... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS ===
> ok
> Test case no : Add a Previously Removed VPN User from the VPC and Test the VPN Connectivity
... === TestName: test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS
===
> ok
> Test case no : Disable the VPN Service on the VPC ... === TestName: test_05_VPC_DisableVPNServiceOnVPC
| Status : SUCCESS ===
> ok
> Test case no : Enabled Previously Dsiabled VPN Access to VPC. ... === TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC
| Status : SUCCESS ===
> ok
> Test case no : Create Nine VPN Users to test the remote.vpn.user.limit=8 Configuration
parameter ... === TestName: test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS
===
> ok
> 
> ----------------------------------------------------------------------
> Ran 7 tests in 1771.352s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message