cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damodar Reddy Talakanti" <damoder.re...@citrix.com>
Subject Re: Review Request 22510: [Windows] Can not create Template from ROOT snapshot. Fixed the same by adding pathSeparator to the DataStoreTO.java
Date Wed, 18 Jun 2014 09:41:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22510/
-----------------------------------------------------------

(Updated June 18, 2014, 9:41 a.m.)


Review request for cloudstack, edison su, Koushik Das, and Min Chen.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6636
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6636


Repository: cloudstack-git


Description
-------

Due to File.separator on windows machine the template creation from snapshot is failing as
it has mis-matched path separator which is windows path separator(\). Fixed the same by adding
getPathSeparator() method to DataStoreTO.java and all it's implementations.


Diffs (updated)
-----

  api/src/com/cloud/agent/api/to/DataStoreTO.java 8d47adc 
  api/src/com/cloud/agent/api/to/NfsTO.java 1c9ee38 
  api/src/com/cloud/agent/api/to/S3TO.java f64fe35 
  api/src/com/cloud/agent/api/to/SwiftTO.java 3b76dad 
  core/src/org/apache/cloudstack/storage/to/ImageStoreTO.java 93c62f6 
  core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java 29e53b0 
  plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java
e96ebf4 

Diff: https://reviews.apache.org/r/22510/diff/


Testing
-------

Tested on Windows 2012 R2 server and on centos. Tested the following use cases.

1. Attach ISO
2. Detach ISO
3. Snapshot creation from root disk
4. Snapshot creation from data disk
5. volume creation from (3)
6. template creation from(3)
7. Launch a VM after registering new template.


Thanks,

Damodar Reddy Talakanti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message