cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 22525: Fixed few reported resource leak issues
Date Mon, 16 Jun 2014 12:17:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22525/#review45741
-----------------------------------------------------------



engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java
<https://reviews.apache.org/r/22525/#comment80702>

    as said before, i think TransactionLegacy must become Closable


otherwise it seems ok, test compiling before applying

- daan Hoogland


On June 13, 2014, 6:35 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22525/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 6:35 a.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed few coverity issues reported.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java f72690e 
> 
> Diff: https://reviews.apache.org/r/22525/diff/
> 
> 
> Testing
> -------
> 
> Built the CS, ran deploy data center post the change.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message