cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request 22452: CLOUDSTACK-6872 : removed the redundant connectToRemote method
Date Fri, 13 Jun 2014 09:10:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22452/#review45597
-----------------------------------------------------------

Ship it!


Ship It!

- Devdeep Singh


On June 11, 2014, 7:31 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22452/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 7:31 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6872
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6872
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Removed the redundant connectTORemote method in Hyper-v Agent. We dont't need this method
as share is domain joined so it has all the required permissions. Removal of this method fixes
this bug also.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
0ad95b8 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs c8e951e 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 372f848

> 
> Diff: https://reviews.apache.org/r/22452/diff/
> 
> 
> Testing
> -------
> 
> tested that volume operations are working fine after removal of this method
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message