cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 22356: Fixed few coverity issues reported
Date Tue, 10 Jun 2014 04:43:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22356/
-----------------------------------------------------------

(Updated June 10, 2014, 4:43 a.m.)


Review request for cloudstack and daan Hoogland.


Changes
-------

Added Latest one


Repository: cloudstack-git


Description
-------

Fixed few coverity issues reported for resource leak, value comparison, invalid loop check
for result set.


Diffs (updated)
-----

  engine/schema/src/com/cloud/upgrade/DatabaseCreator.java 91ef318 
  engine/schema/src/com/cloud/upgrade/DatabaseIntegrityChecker.java c20a418 
  engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java 0761c9f 
  framework/db/src/com/cloud/utils/crypt/EncryptionSecretKeyChanger.java 58584f9 
  framework/db/src/com/cloud/utils/db/Merovingian2.java 6eeea9f 
  framework/db/src/com/cloud/utils/db/ScriptRunner.java 6614527 
  framework/db/src/com/cloud/utils/db/TransactionLegacy.java ac0ea21 
  server/src/com/cloud/test/IPRangeConfig.java 1d56471 
  usage/src/com/cloud/usage/UsageSanityChecker.java 5e6123b 
  utils/src/com/cloud/utils/crypt/EncryptionSecretKeySender.java 086e8a8 

Diff: https://reviews.apache.org/r/22356/diff/


Testing
-------

1.Built the code and found no issues.
2.Built the simulator and ran a deploy datacenter with the changes.


Thanks,

Santhosh Edukulla


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message