cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajani Karuturi" <rajanikarut...@gmail.com>
Subject Re: Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Date Sat, 07 Jun 2014 10:21:22 GMT


> On June 6, 2014, 6:24 p.m., Nitin Mehta wrote:
> > Hi Santosh - We should add the domain id column in the vm_template table. IMHO this
is not the right fix but will mask problems where domain id is coming out -1. We need to see
why domainid is coming out as -1 and solve it in the right way rather than masking it.
> 
> Rajani Karuturi wrote:
>     This is just a point fix for the 4.4 release to avoid schema/major changes at this
point of the release.
>     Also the right fix is to not add another column as we already have that info from
account id. PartOf interface needs to be fixed to use the available information.

I see that santhosh already responded on the jira page https://issues.apache.org/jira/browse/CLOUDSTACK-6793?focusedCommentId=14020258


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/#review44945
-----------------------------------------------------------


On June 6, 2014, 9:28 a.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19874/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 9:28 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6793
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6793
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 1. Added fix to retrieve the correct domain id for a given accountid. vm_template table
and respective vo, does not have a domain id information.
> 2. Added logic to retrieve correct domainid for a given accountid, only when an invalid
domainid is retrieved. Throw an exception in case of invalid domain id.
> 3. Now, creation of tags is getting successful post the fix.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd 
>   engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed 
>   server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7 
> 
> Diff: https://reviews.apache.org/r/19874/diff/
> 
> 
> Testing
> -------
> 
> Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag |
Status : SUCCESS ===
> ok
> Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag
| Status : SUCCESS ===
> ok
> Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status
: SUCCESS ===
> ok
> Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag
| Status : SUCCESS ===
> ok
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message