cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Review Request 19874: CLOUDSTACK-6793 : Fixed an Invalid Domain Id Issue
Date Fri, 06 Jun 2014 09:28:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19874/
-----------------------------------------------------------

Review request for cloudstack, daan Hoogland and Kishan Kavala.


Bugs: CLOUDSTACK-6793
    https://issues.apache.org/jira/browse/CLOUDSTACK-6793


Repository: cloudstack-git


Description
-------

1. Added fix to retrieve the correct domain id for a given accountid. vm_template table and
respective vo, does not have a domain id information.
2. Added logic to retrieve correct domainid for a given accountid, only when an invalid domainid
is retrieved. Throw an exception in case of invalid domain id.
3. Now, creation of tags is getting successful post the fix.


Diffs
-----

  engine/schema/src/com/cloud/user/dao/AccountDao.java 2f737cd 
  engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 4bc23ed 
  server/src/com/cloud/tags/TaggedResourceManagerImpl.java fa7fcb7 

Diff: https://reviews.apache.org/r/19874/diff/


Testing
-------

Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status
: SUCCESS ===
ok
Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag
| Status : SUCCESS ===
ok
Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status
: SUCCESS ===
ok
Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status
: SUCCESS ===
ok


Thanks,

Santhosh Edukulla


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message