> On May 27, 2014, 6:55 p.m., Chiradeep Vittal wrote:
> > In EC2engine.java, I still see code blocks such as if (foo) \n blargh() reformatted
to if (foo) blargh
> >
> > Please add prachidamle as a reviewer
>
> Dmitry Batkovich wrote:
> In new review? https://reviews.apache.org/r/21936/
>
> Chiradeep Vittal wrote:
> Ah, ok. RB lets you update the old review. It said "updated 4 minutes ago", so I
assumed it was an update to the original review request
>
>
> Dmitry Batkovich wrote:
> ok, I updated this old review and add reviewer
Hello anybody, guys any response?=)
- Dmitry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21776/#review44020
-----------------------------------------------------------
On May 27, 2014, 8:04 p.m., Dmitry Batkovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21776/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 8:04 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Prachi Damle.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for
supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
>
> continuation of https://reviews.apache.org/r/17586/
>
>
> Diffs
> -----
>
> awsapi/conf/ec2-service.properties.in 82f5ad8
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
> awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
> awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
> awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
> awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
> awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
> awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
> awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
> awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
> awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21776/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitry Batkovich
>
>
|