cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 22226: Make set-eclipse-profile.sh work with bsd/mac sed
Date Thu, 05 Jun 2014 07:41:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22226/#review44803
-----------------------------------------------------------

Ship it!


95314ac4528163cae7df609e7d44779e4f90e904

- daan Hoogland


On June 4, 2014, 8:52 a.m., Leo Simons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22226/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 8:52 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> bsd/mac sed interprets wants -e to be completely clear that the next arg is the expression
instead of an argument to -i.
> 
> 
> Diffs
> -----
> 
>   tools/eclipse/set-eclipse-profile.sh 1abc662 
> 
> Diff: https://reviews.apache.org/r/22226/diff/
> 
> 
> Testing
> -------
> 
> Successfully ran fixed script on stock mac install. Not tested on linux but this is common
portability error so _should_ be fine.
> 
> 
> Thanks,
> 
> Leo Simons
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message