cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
Date Thu, 05 Jun 2014 06:03:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44801
-----------------------------------------------------------


Commit 96272f4cde4e1012da820264ff91c43a9ec255c4 in cloudstack's branch refs/heads/master from
Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=96272f4 ]

CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py

Conflicts:
	test/integration/smoke/test_non_contigiousvlan.py


- ASF Subversion and Git Services


On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 11:45 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6776
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6776
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  The test case fails whenever hard coded values overlap with already configured VLAN
in the physical network. Removed hard code VLAN ids and used the common function to get unused
VLAN ids from the physical network dynamically.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_non_contigiousvlan.py 90235ec 
> 
> Diff: https://reviews.apache.org/r/22197/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan
| Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
> 
> OK
> ~
> ~
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message