cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
Date Wed, 04 Jun 2014 09:49:52 GMT


> On June 3, 2014, 12:27 p.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_non_contigiousvlan.py, line 47
> > <https://reviews.apache.org/r/22197/diff/2/?file=602802#file602802line47>
> >
> >     As well, can we run these changes once and see no issues if its possible?

Yes I did run it again after the changes.


> On June 3, 2014, 12:27 p.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_non_contigiousvlan.py, line 45
> > <https://reviews.apache.org/r/22197/diff/2/?file=602802#file602802line45>
> >
> >     It seems we are not reading test data. Can we check that?

It is not required here. As only test data the test case was earlier reading was vlan ids.
And now we have removed that data and getting the free vlan ids through code from the setup.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44616
-----------------------------------------------------------


On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 11:45 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6776
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6776
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  The test case fails whenever hard coded values overlap with already configured VLAN
in the physical network. Removed hard code VLAN ids and used the common function to get unused
VLAN ids from the physical network dynamically.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_non_contigiousvlan.py 90235ec 
> 
> Diff: https://reviews.apache.org/r/22197/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan
| Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
> 
> OK
> ~
> ~
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message