cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request 21908: Fix for CLOUDSTACK-6464
Date Tue, 03 Jun 2014 16:41:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21908/#review44634
-----------------------------------------------------------


Actually, this would be fixed by changing the upgraded db to have vlan:// in the vlan_id table,
as fresh installs do. This bug exists because the IpAssocCommand crafted by the management
server sends the ips broadcastUri in a different format from the network/nic setups. We're
actually discussing how to fix that right now, and whether it makes sense to update the db
during upgrade to match what 4.3+ does currently, or change 4.3+ back.

- Marcus Sorensen


On May 26, 2014, 12:25 p.m., Anders Lannerb├Ąck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21908/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 12:25 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for CLOUDSTACK-6464.  This patch is against 4.3-branch.
> 
> The original code adds broadcastUri on the format "vlan://100", but later looks for HashMap
keys without the "vlan://" bit.  This causes new interfaces be created with duplicate MACs
and the routers become unusable.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
36382e3 
> 
> Diff: https://reviews.apache.org/r/21908/diff/
> 
> 
> Testing
> -------
> 
> Used to repair our production Cloudstack instance.
> 
> 
> Thanks,
> 
> Anders Lannerb├Ąck
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message