cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
Date Tue, 03 Jun 2014 11:22:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44612
-----------------------------------------------------------



test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79031>

    Is it ok to move to test data?



test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79034>

    We assigned self.vlan to Services()... and again list unpacking is using self.vlan, so
self.vlan was overwritten, please check.



test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79032>

    It should be "is None" comparison. 



test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79033>

    Do we want to fail in setup or raise exception? As such its a setup which is having issue
not the test case..


- Santhosh Edukulla


On June 3, 2014, 10:57 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 10:57 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6776
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6776
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  The test case fails whenever hard coded values overlap with already configured VLAN
in the physical network. Removed hard code VLAN ids and used the common function to get unused
VLAN ids from the physical network dynamically.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_non_contigiousvlan.py 90235ec 
> 
> Diff: https://reviews.apache.org/r/22197/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan
| Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
> 
> OK
> ~
> ~
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message