cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajani Karuturi" <rajanikarut...@gmail.com>
Subject Re: Review Request 22194: Fixed Resource leak reported by coverity
Date Tue, 03 Jun 2014 10:41:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22194/#review44608
-----------------------------------------------------------



engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java
<https://reviews.apache.org/r/22194/#comment79029>

    from the javadoc "Calling the method close on a Statement object that is already closed
has no effect." so, this will not be an issue


- Rajani Karuturi


On June 3, 2014, 9:31 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22194/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 9:31 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed Resource leak (RESOURCE_LEAK)
>     11. overwrite_var: Overwriting "pstmt" in "pstmt = conn.prepareStatement("INSERT
INTO `cloud`.`ldap_configuration`(hostname, port) VALUES(?,?)")" leaks the resource that "pstmt"
refers to.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132 
> 
> Diff: https://reviews.apache.org/r/22194/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message