cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 18677: CLOUDSTACK-3272
Date Mon, 02 Jun 2014 17:15:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review44511
-----------------------------------------------------------


Commit eb8e630f24f5359b6c2e9a74bf12ea338df66a41 in cloudstack's branch refs/heads/master from
Rohit Yadav
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=eb8e630 ]

AlertGenerator: Fix NPE from CLOUDSTACK-3272

There was a commit 4b89a45e571a34dff0191d501089aa9b1046bc08 on master which was
added by "root@devcloud.apache.org" with no committer signature so I cannot tell
whom to reach. In the code it looks like they forgot to initialize the static
config dao variable which is causing NPE on master. The fix simply initializes
the s_configDao with injected configDao object.

Signed-off-by: Rohit Yadav <bhaisaab@apache.org>


- ASF Subversion and Git Services


On May 6, 2014, 6:53 a.m., Sonal Ojha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 6:53 a.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-3272
>     https://issues.apache.org/jira/browse/CLOUDSTACK-3272
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> At present, there are multiple event types that are generated by CS, action events,usage
events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to
introduce global setting config parameters to specify which category of events to be published
or not be published on the event bus.
> 
> 
> Diffs
> -----
> 
>   engine/components-api/src/com/cloud/event/UsageEventUtils.java f1707bd 
>   engine/components-api/src/com/cloud/network/NetworkStateListener.java 0a5e033 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
96dafe9 
>   server/src/com/cloud/configuration/Config.java 89f47d4 
>   server/src/com/cloud/event/ActionEventUtils.java 363bb93 
>   server/src/com/cloud/event/AlertGenerator.java 5982eea 
>   server/src/com/cloud/network/IpAddressManagerImpl.java 746221f 
>   server/src/com/cloud/storage/StorageManagerImpl.java c27a457 
>   server/src/com/cloud/storage/listener/SnapshotStateListener.java 45f0c5d 
>   server/src/com/cloud/storage/listener/VolumeStateListener.java 1ab2755 
>   server/src/com/cloud/test/DatabaseConfig.java 07e4348 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbca21b 
>   server/src/com/cloud/vm/UserVmStateListener.java 6631ca3 
>   server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java e7581d6 
> 
> Diff: https://reviews.apache.org/r/18677/diff/
> 
> 
> Testing
> -------
> 
> Successfully tested publishing / not publishing of various events based on the global
parameter publish.*.events.
> 
> 
> File Attachments
> ----------------
> 
> Working patch for master (latest git commit 55f53e13e)
>   https://reviews.apache.org/media/uploaded/files/2014/04/15/a6b65b2b-32ea-41d1-97e5-b9958d8b8841__0001-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> Works on commit 6c44c0661dae0e9de4ed53fad8951e72dbbd3335
>   https://reviews.apache.org/media/uploaded/files/2014/05/05/ea7c6ce6-7750-456a-96c0-41aa1aee9437__0002-CLOUDSTACK-3272-Latest-changes-to-add-global-configu.patch
> 
> 
> Thanks,
> 
> Sonal Ojha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message