cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 22093: VPC's VR missing public NIC eth1
Date Mon, 02 Jun 2014 12:14:24 GMT


> On June 2, 2014, 8:32 a.m., Joris van Lieshout wrote:
> > Another issue might be that new entries (we see this on ACS 4.3 with XenServer)
are created without vlan://
> > The name of the field is vlan_id and not BroadcastURI so keeping it an integer only
would make more sense to me. And then use null for untagged vlans. If we would really want
a bURI then we should also rename the field.

You are right but that is a different issue. The field is a string type and called id. This
is kind of against the acs db conventions.


- daan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44480
-----------------------------------------------------------


On May 30, 2014, 9 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 9 p.m.)
> 
> 
> Review request for cloudstack and Marcus Sorensen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132 
> 
> Diff: https://reviews.apache.org/r/22093/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message