Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (athena.apache.org: domain of koushik.das@citrix.com
 designates 103.14.252.240 as permitted sender)
From: Koushik Das <koushik.das@citrix.com>
To: "<dev@cloudstack.apache.org>" <dev@cloudstack.apache.org>
Subject: Re: How is this working?
Thread-Topic: How is this working?
Thread-Index: 
 AQHPaE2vDbHPaJRdvE2+q/1wcI4lg5sxmoOAgACQjpb//4z3AP//kL2AgAB2zYCAAKe7gA==
Date: Tue, 6 May 2014 03:55:24 +0000
Message-ID: <B16FA36B-CFA7-4A64-B202-9B1FF458A330@citrix.com>
References: 
 <CACOnxCgVV4oHp-J8Prnez6bY_NG1XEF2Mr2HHjeb1U8Wh_SwRg@mail.gmail.com>
 <CF8D1CE9.3CA37%nitin.mehta@citrix.com>
 <CACOnxChJRwpz1sMpkNSL6adSzqTGpM98yGDk4de4n-UBaDDHog@mail.gmail.com>
In-Reply-To: 
 <CACOnxChJRwpz1sMpkNSL6adSzqTGpM98yGDk4de4n-UBaDDHog@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <41BD36671E968143A85DF6F1ED400288@citrix.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

The dashboard in CS UI is impacted by this.

On 05-May-2014, at 11:25 PM, Mike Tutkowski <mike.tutkowski@solidfire.com> =
wrote:

> OK, I can log a JIRA ticket for this.
>=20
> Thanks
>=20
>=20
> On Mon, May 5, 2014 at 11:49 AM, Nitin Mehta <Nitin.Mehta@citrix.com> wro=
te:
>=20
>> Ideally, we should deprecate the column since its not used and causes
>> confusion.
>> Setting to this value wouldn't help because this column is never updated
>> regularly.
>>=20
>> On 05/05/14 10:28 AM, "Mike Tutkowski" <mike.tutkowski@solidfire.com>
>> wrote:
>>=20
>>> How's about I just check this code into master?
>>>=20
>>> poolVO.setUsedBytes(mspAnswer.getPoolInfo().getCapacityBytes() -
>>> mspAnswer.getPoolInfo().getAvailableBytes());
>>>=20
>>> It is patterned off of the PrimaryDataStoreHelper.attachHost logic, whi=
ch
>>> looks like this:
>>>=20
>>> pool.setUsedBytes(existingInfo.getCapacityBytes() -
>>> existingInfo.getAvailableBytes());
>>>=20
>>>=20
>>> On Mon, May 5, 2014 at 10:21 AM, Nitin Mehta <Nitin.Mehta@citrix.com>
>>> wrote:
>>>=20
>>>> This column is not used for calculating capacity for pool.
>>>> We have always used op host capacity table. Nevertheless please do fil=
e
>>>> a
>>>> bug
>>>>=20
>>>> Thanks,
>>>> -Nitin
>>>> ________________________________________
>>>> From: Mike Tutkowski [mike.tutkowski@solidfire.com]
>>>> Sent: Monday, May 05, 2014 9:12 PM
>>>> To: dev@cloudstack.apache.org
>>>> Subject: Re: How is this working?
>>>>=20
>>>> My storage plug-in actually uses a custom host listener, so I have not
>>>> encountered this issue.
>>>>=20
>>>> I don't remember off hand if it was in 4.2 or 4.3, but at some point
>>>> someone changed the storage_pool table's available_bytes column to be
>>>> used_bytes.
>>>>=20
>>>> It looks like this code you reference was missed.
>>>>=20
>>>>=20
>>>> On Mon, May 5, 2014 at 4:35 AM, Koushik Das <koushik.das@citrix.com>
>>>> wrote:
>>>>=20
>>>>> I came across this code snippet in hostConnect() method in
>>>>> DefaultHostListener.java. Look at the line where the used bytes is
>>>> set on
>>>>> the poolVO. This looks like a serious bug. Looking at the history thi=
s
>>>> code
>>>>> has been there since a year. Has anyone encountered any issues with
>>>> primary
>>>>> storage capacity?
>>>>>=20
>>>>> ModifyStoragePoolAnswer mspAnswer =3D (ModifyStoragePoolAnswer)answer=
;
>>>>> =8A..
>>>>> StoragePoolVO poolVO =3D this.primaryStoreDao.findById(poolId);
>>>>> poolVO.setUsedBytes(mspAnswer.getPoolInfo().getAvailableBytes());
>>>>> poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
>>>>> primaryStoreDao.update(pool.getId(), poolVO);
>>>>>=20
>>>>>=20
>>>>> -Koushik
>>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>> --
>>>> *Mike Tutkowski*
>>>> *Senior CloudStack Developer, SolidFire Inc.*
>>>> e: mike.tutkowski@solidfire.com
>>>> o: 303.746.7302
>>>> Advancing the way the world uses the
>>>> cloud<http://solidfire.com/solution/overview/?video=3Dplay>
>>>> * *
>>>>=20
>>>=20
>>>=20
>>>=20
>>> --
>>> *Mike Tutkowski*
>>> *Senior CloudStack Developer, SolidFire Inc.*
>>> e: mike.tutkowski@solidfire.com
>>> o: 303.746.7302
>>> Advancing the way the world uses the
>>> cloud<http://solidfire.com/solution/overview/?video=3Dplay>
>>> * *
>>=20
>>=20
>=20
>=20
> --=20
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud<http://solidfire.com/solution/overview/?video=3Dplay>
> *=99*